launchpad-reviewers team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

Deryck Hodge has proposed merging lp:~deryck/launchpad/fix-heat-help-link into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #599480 Update link to bug heat code in heat help popup
  https://bugs.launchpad.net/bugs/599480


Once we moved the code to calculate bug heat from pure Python to plpython,
the link to the file in the bug heat help pop-up was broken.  This small
branch fixes that link.

Since the method is buried in the large file trusted.sql and the line
numbers can change with additions to the file, I decided to change the
langauge around the link to make the link hardened against these kinds of
future changes.  This does make it harder to directly link to the function,
which makes it harder for the user to find.  But there's the trade off
between constantly updating this link and discoverability.  I'm completely
open to other linking or language suggestions.

Current link now reads:

To view the code that calculates bug heat, look for
calculate_bug_heat in the file trusted.sql

Where trusted.sql links to:
http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-devel/annotate/head:/database/schema/trusted.sql

Cheers,
deryck
-- 
https://code.launchpad.net/~deryck/launchpad/fix-heat-help-link/+merge/29856
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/fix-heat-help-link into lp:launchpad/devel.

=== modified file 'lib/lp/bugs/help/bug-heat.html'
--- lib/lp/bugs/help/bug-heat.html	2010-04-22 09:23:00 +0000
+++ lib/lp/bugs/help/bug-heat.html	2010-07-14 11:01:43 +0000
@@ -181,10 +181,10 @@
       </tr>
     </table>
 
-    <p>
+    <p>To view the code that calculates bug heat, look for
+      calculate_bug_heat in the file
       <a target="_blank"
-      href="http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-devel/annotate/head:/lib/lp/bugs/scripts/bugheat.py";>
-      View the Launchpad code that calculates bug heat &gt;</a>.
+      href="http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-devel/annotate/head:/database/schema/trusted.sql";>trusted.sql</a>
     </p>
 
   </body>