launchpad-reviewers team mailing list archive

[Michael Hudson <michael.hudson@xxxxxxxxxxxxx>]

Michael Hudson has proposed merging lp:~mwhudson/launchpad/remove-commit-from-make_running_import into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


Hi, this branch just deletes a now-unnecessary commit in a test helper.  It should make the test suite a few seconds faster :-)
-- 
https://code.launchpad.net/~mwhudson/launchpad/remove-commit-from-make_running_import/+merge/30018
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mwhudson/launchpad/remove-commit-from-make_running_import into lp:launchpad/devel.

=== modified file 'lib/canonical/launchpad/testing/codeimporthelpers.py'
--- lib/canonical/launchpad/testing/codeimporthelpers.py	2010-02-18 02:31:34 +0000
+++ lib/canonical/launchpad/testing/codeimporthelpers.py	2010-07-15 15:21:04 +0000
@@ -14,7 +14,6 @@
 from datetime import datetime, timedelta
 
 from pytz import UTC
-import transaction
 from zope.component import getUtility
 from zope.security.proxy import removeSecurityProxy
 
@@ -56,7 +55,6 @@
         code_import = factory.makeCodeImport()
     if machine is None:
         machine = factory.makeCodeImportMachine(set_online=True)
-    transaction.commit() # Commit so factory created persons are valid
     # The code import must be in a reviewed state.
     if code_import.review_status != CodeImportReviewStatus.REVIEWED:
         code_import.updateFromData(