launchpad-reviewers team mailing list archive

[James Westby <jw+debian@xxxxxxxxxxxxxxx>]

The proposal to merge lp:~james-w/launchpad/expose-blueprints into lp:launchpad/devel has been updated.

Description changed to:

Hi,

Summary

Expose some blueprint attributes and a couple of methods over the API.

Proposed fix

Add exported() in a bunch of places.

Pre-implementation notes

None.

Implementation details

It exports the basics of ISpecification, plus 3 methods that may be useful
to people for getting blueprints.

I added two new methods to IHasSpecifications, as if we exposed the existing
attributes we would serve the collections when just getting the specification.

I'm not entirely sure what getValidSpecifications means, given its apparently
inconsistent implementations, so perhaps it is not worth exposing it.

A getSpecifications() similar to searchTasks() would be great, but the API isn't
there for that.

Also, I guess there may be opposition to exposing the whiteboard, but I think
if it is there then it should be exposed, and as it will be one of the most
used attributes not having it would make the API close to useless, at least for
removing the screen scraping in launchpad-work-items-tracker.

Tests

./bin/test -s lp.blueprints.tests -m test_webservice

Demo and Q/A

I'll test it with launchpadlib once it is on edge.

lint

./lib/lp/blueprints/model/specification.py
     336: E222 multiple spaces after operator
     375: E222 multiple spaces after operator
     681: E231 missing whitespace after ','
./lib/lp/blueprints/stories/standalone/sprint-links.txt
      12: source has bad indentation.
      19: source has bad indentation.
      32: source has bad indentation.
      41: source has bad indentation.
      65: source exceeds 78 characters.
      65: source has bad indentation.
      81: source has bad indentation.
      86: source has bad indentation.
      98: source has bad indentation.
     105: source has bad indentation.
./lib/lp/testing/factory.py
     824: E231 missing whitespace after ','
    1823: E231 missing whitespace after ','
    1946: E301 expected 1 blank line, found 0

None of which I am inclined to fix, as they are not in code that I have
changed or would require updating too much of the file to be worthwhile.

-- 
https://code.launchpad.net/~james-w/launchpad/expose-blueprints/+merge/30026
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~james-w/launchpad/expose-blueprints into lp:launchpad/devel.