launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/launchpad/test-cruft-app into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers): code


Removes test boilerplate that we no longer need from app, and fixes lint in affected tests.
-- 
https://code.launchpad.net/~jtv/launchpad/test-cruft-app/+merge/30199
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/test-cruft-app into lp:launchpad/devel.

=== modified file 'lib/lp/app/browser/tests/test_launchpadroot.py'
--- lib/lp/app/browser/tests/test_launchpadroot.py	2010-04-08 11:40:09 +0000
+++ lib/lp/app/browser/tests/test_launchpadroot.py	2010-07-18 00:35:51 +0000
@@ -5,9 +5,6 @@
 
 __metaclass__ = type
 
-import unittest
-
-
 from BeautifulSoup import BeautifulSoup, SoupStrainer
 
 from zope.component import getUtility
@@ -73,8 +70,3 @@
         self.failUnless(
             content.find('a', href='+featuredprojects'),
             "Cannot find the +featuredprojects link on the first page")
-
-
-def test_suite():
-    return unittest.TestLoader().loadTestsFromName(__name__)
-

=== modified file 'lib/lp/app/tests/test_help.py'
--- lib/lp/app/tests/test_help.py	2009-08-20 17:23:53 +0000
+++ lib/lp/app/tests/test_help.py	2010-07-18 00:35:51 +0000
@@ -1,4 +1,4 @@
-# Copyright 2009 Canonical Ltd.  This software is licensed under the
+# Copyright 2009-2010 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Tests for the help system integration."""
@@ -70,7 +70,3 @@
         self.assertHasHelpFolderView(
             TranslationsLayer,
             os.path.join(ROOT, 'lib/lp/translations/help'))
-
-
-def test_suite():
-    return unittest.TestLoader().loadTestsFromName(__name__)