← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~gmb/launchpad/dont-piss-the-losas-off-bug-596877 into lp:launchpad

To: Graham Binns <graham@xxxxxxxxxxxxx>
From: Robert Collins <robertc@xxxxxxxxxxxxxxxxx>
Date: Mon, 19 Jul 2010 12:47:46 -0000
In-reply-to: <20100717192315.30884.82975.launchpad@loganberry.canonical.com>
Reply-to: mp+30186@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information
Shouldn't the permission check be in the model? the LBYP idiom seems likely to miss things...
-- 
https://code.launchpad.net/~gmb/launchpad/dont-piss-the-losas-off-bug-596877/+merge/30186
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~gmb/launchpad/dont-piss-the-losas-off-bug-596877 into lp:launchpad.

References

[Merge] lp:~gmb/launchpad/dont-piss-the-losas-off-bug-596877 into lp:launchpad
From: Graham Binns, 2010-07-17