launchpad-reviewers team mailing list archive

[Brian Murray <brian@xxxxxxxxxx>]

Brian Murray has proposed merging lp:~brian-murray/launchpad/cache-official-tags-portlet into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


The bug's tags portlet for bug targets is not cached which is unfortunate because it is a perfect thing for caching as official bug tags do not change frequently nor do the most popular tags.
-- 
https://code.launchpad.net/~brian-murray/launchpad/cache-official-tags-portlet/+merge/30557
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~brian-murray/launchpad/cache-official-tags-portlet into lp:launchpad/devel.

=== modified file 'lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt'
--- lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt	2009-09-20 16:05:43 +0000
+++ lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt	2010-07-21 16:56:21 +0000
@@ -3,13 +3,15 @@
      xmlns:i18n="http://xml.zope.org/namespaces/i18n";
      class="portletBody">
   <div class="section" tal:define="tags_cloud_data view/tags_cloud_data">
-    <h2 tal:condition="tags_cloud_data">Tags</h2>
-    <div style="text-align: justify">
-      <a tal:repeat="tag_info view/tags_cloud_data"
-         tal:content="tag_info/tag"
-         tal:attributes="href tag_info/url;
-                         style string:font-size: ${tag_info/factor}em" />
-    </div>
+    <tal:tags content="cache:public, 60 minutes">
+        <h2 tal:condition="tags_cloud_data">Tags</h2>
+        <div style="text-align: justify">
+          <a tal:repeat="tag_info view/tags_cloud_data"
+             tal:content="tag_info/tag"
+             tal:attributes="href tag_info/url;
+                            style string:font-size: ${tag_info/factor}em" />
+        </div>
+    </tal:tags>
   </div>
 </div>