← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~jelmer/launchpad/607677-grey-disabled-archives into lp:launchpad/devel

 

Jelmer Vernooij has proposed merging lp:~jelmer/launchpad/607677-grey-disabled-archives into lp:launchpad/devel.

Requested reviews:
  Michael Nelson (michael.nelson): ui
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #607677 disabled copy archives should be visualized as such
  https://bugs.launchpad.net/bugs/607677


This simple change greys out disabled archives in the per-distribution copy archive list.

An example of how it looks can be found at http://people.canonical.com/~jelmer/screenshot-disabled-archives.png
-- 
https://code.launchpad.net/~jelmer/launchpad/607677-grey-disabled-archives/+merge/30627
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jelmer/launchpad/607677-grey-disabled-archives into lp:launchpad/devel.
=== modified file 'lib/lp/soyuz/templates/distribution-archive-list.pt'
--- lib/lp/soyuz/templates/distribution-archive-list.pt	2009-08-13 14:00:06 +0000
+++ lib/lp/soyuz/templates/distribution-archive-list.pt	2010-07-22 09:51:10 +0000
@@ -37,7 +37,8 @@
         </thead>
         <tbody>
           <tal:batch_repeat repeat="archive batch">
-            <tr tal:define="build_counts archive/getBuildCounters">
+          <tr tal:attributes="class python:not archive.enabled and 'greyed-out'"
+              tal:define="build_counts archive/getBuildCounters">
               <td tal:content="archive/date_created/fmt:approximatedate" />
               <td>
                 <a tal:attributes="href archive/fmt:url"