launchpad-reviewers team mailing list archive

[Māris Fogels <mfogels@xxxxxxxxx>]

Māris Fogels has proposed merging lp:~mars/launchpad/activate-xvfb-error-log into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


Hi,

This branch activates the error log for the Xvfb server.  Without this xvfb will toss all of its startup errors to /dev/null, making it impossible to diagnose startup problems.

I also rewrote the '-s' argument to --long-form for clarity.  I'm the only person that reads this stuff regularly, so this should help other maintainers in future.

This patch has been tested locally and on buildbot.


Maris
-- 
https://code.launchpad.net/~mars/launchpad/activate-xvfb-error-log/+merge/31154
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mars/launchpad/activate-xvfb-error-log into lp:launchpad/devel.

=== modified file 'test_on_merge.py'
--- test_on_merge.py	2010-04-28 20:18:48 +0000
+++ test_on_merge.py	2010-07-28 14:35:58 +0000
@@ -138,8 +138,8 @@
     os.chdir(here)
     cmd = [
         'xvfb-run',
-        '-s',
-        "'-screen 0 1024x768x24'",
+        "--error-file=/var/tmp/xvfb-errors.log",
+        "--server-args='-screen 0 1024x768x24'",
         os.path.join(here, 'bin', 'test')] + sys.argv[1:]
     command_line = ' '.join(cmd)
     print command_line