launchpad-reviewers team mailing list archive

[Tim Penhey <tim.penhey@xxxxxxxxxxxxx>]

On Wed, 04 Aug 2010 09:41:13 you wrote:
> On Tue, Aug 3, 2010 at 10:33 PM, Tim Penhey <tim.penhey@xxxxxxxxxxxxx> 
wrote:
> > Tim Penhey has proposed merging
> > lp:~thumper/launchpad/branch-target-adapters into lp:launchpad/devel.
> 
> ...
> 
> > As part of the on-going work to make the smart server understand the
> > short lp: style urls for private branches, I need some extra branch
> > target adapters.  This branch adds the adapters for IProductSeries ->
> > IBranchTarget, and IDistributionSourcePackage -> IBranchTarget.
> 
> I'm curious. This wasn't a part of the work we did at the Epic... why
> is this needed?
> 
> jml

It is part of that "minor" bit that was left :-)

It makes the code that allows the branch creation to work when given a short 
name, and the ability to set the linked branch.

We use the ILinkedBranchTraverser to get one of:
  Product, ProductSeries, SourcePackage, DistributionSourcePackage

We then adapt that to an IBranchTarget.  We then use the target to get the 
IBranchNamespace for the requester.  Then we can check branch names to make 
sure there isn't a conflict.

The the guts of the reason is to go from something that can have a linked 
branch to a branch namespace we go through a branch target.

Tim
-- 
https://code.launchpad.net/~thumper/launchpad/branch-target-adapters/+merge/31698
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~thumper/launchpad/branch-target-adapters into lp:launchpad/devel.