launchpad-reviewers team mailing list archive

[James Westby <jw+debian@xxxxxxxxxxxxxxx>]

James Westby has proposed merging lp:~james-w/launchpad/stop-publishing-nagging into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


Stop the nagging from test_publishing.py about removeSecurityProxy.

It's test setup code so it is fine for it to be removing the proxy
to complete the setup.

Thanks,

James

-- 
https://code.launchpad.net/~james-w/launchpad/stop-publishing-nagging/+merge/31851
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~james-w/launchpad/stop-publishing-nagging into lp:launchpad/devel.

=== modified file 'lib/lp/soyuz/tests/test_publishing.py'
--- lib/lp/soyuz/tests/test_publishing.py	2010-08-02 02:13:52 +0000
+++ lib/lp/soyuz/tests/test_publishing.py	2010-08-05 15:36:12 +0000
@@ -146,8 +146,7 @@
             PackageUploadStatus.DONE: 'setDone',
             PackageUploadStatus.ACCEPTED: 'setAccepted',
             }
-        naked_package_upload = remove_security_proxy_and_shout_at_engineer(
-            package_upload)
+        naked_package_upload = removeSecurityProxy(package_upload)
         method = getattr(
             naked_package_upload, status_to_method[upload_status])
         method()
@@ -225,8 +224,7 @@
             changes_file_name=changes_file_name,
             changes_file_content=changes_file_content,
             upload_status=upload_status)
-        naked_package_upload = remove_security_proxy_and_shout_at_engineer(
-            package_upload)
+        naked_package_upload = removeSecurityProxy(package_upload)
         naked_package_upload.addSource(spr)
 
         if filename is None: