launchpad-reviewers team mailing list archive

[Paul Hummer <paul@xxxxxxxxxxxxxxxxxxxx>]

Paul Hummer has proposed merging lp:~rockstar/launchpad/recipe-build-table into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #604901 Build records table needs tweaks
  https://bugs.launchpad.net/bugs/604901


This branch is small, and fixes bug #604901 - the recipe table had it's "narrow-listing" class removed and the order in which the builds were listing reversed.
-- 
https://code.launchpad.net/~rockstar/launchpad/recipe-build-table/+merge/31882
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rockstar/launchpad/recipe-build-table into lp:launchpad/devel.

=== modified file 'lib/lp/code/browser/sourcepackagerecipe.py'
--- lib/lp/code/browser/sourcepackagerecipe.py	2010-08-02 02:36:32 +0000
+++ lib/lp/code/browser/sourcepackagerecipe.py	2010-08-05 20:17:44 +0000
@@ -166,7 +166,6 @@
             builds.append(build)
             if len(builds) >= 5:
                 break
-        builds.reverse()
         return builds
 
 

=== modified file 'lib/lp/code/browser/tests/test_sourcepackagerecipe.py'
--- lib/lp/code/browser/tests/test_sourcepackagerecipe.py	2010-07-31 14:46:11 +0000
+++ lib/lp/code/browser/tests/test_sourcepackagerecipe.py	2010-08-05 20:17:44 +0000
@@ -610,7 +610,7 @@
         set_day(build5, 12)
         set_day(build6, 11)
         self.assertEqual(
-            [build5, build4, build3, build2, build1], view.builds)
+            [build1, build2, build3, build4, build5], view.builds)
 
     def test_request_builds_page(self):
         """Ensure the +request-builds page is sane."""

=== modified file 'lib/lp/code/templates/sourcepackagerecipe-index.pt'
--- lib/lp/code/templates/sourcepackagerecipe-index.pt	2010-07-21 14:01:51 +0000
+++ lib/lp/code/templates/sourcepackagerecipe-index.pt	2010-08-05 20:17:44 +0000
@@ -82,7 +82,7 @@
   <div class="yui-g">
     <div class="portlet">
       <h2>Build records</h2>
-        <table class="listing narrow-listing" style='margin-bottom: 1em;'>
+        <table class="listing" style='margin-bottom: 1em;'>
           <thead>
             <tr>
               <th>Status</th>