launchpad-reviewers team mailing list archive

[Max Bowsher <maxb@xxxxxxx>]

Review: Needs Fixing
On Standards-Version ... is anyone checking or caring whether we are compliant? On never-for-distro packages, I sometimes set Standards-Version to 0. If we are updating it, there should be words in the debian/changelog entry stating that no changes were required, or what changes were needed.


On the description changes... is "meta-package", hyphenated, the standard? I've only seen it hyphenless.


On the copyright file changes... the debian/changelog declares the package dates back to 2005 - from what source to you derive 2009-2010 ?


On the ${misc:Depends} addition... harmless and pacifies lintian, though a bit redundant in a metapackage. Might be better to place it on a final line on its own, so it doesn't keep getting involved in the diffs when people add packages.
-- 
https://code.launchpad.net/~jelmer/meta-lp-deps/lintian/+merge/31745
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jelmer/meta-lp-deps/lintian into lp:meta-lp-deps.