launchpad-reviewers team mailing list archive

["j.c.sackett" <jonathan.sackett@xxxxxxxxxxxxx>]

j.c.sackett has proposed merging lp:~jcsackett/launchpad/member-icons-title into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #614649 Title for "member of" icons unhelpful
  https://bugs.launchpad.net/bugs/614649


Summary

Fixes a trivial text problem on membership icons by changing hover over to "Member of [team]" instead of "Icon of [team]," which is now the alt text.

Proposed fix

Change the text.

Pre-implementation notes

Spoke with Curtis, and agreed that "member of..." is more informative than "icon of..."

Implementation details

Icon of... was made alt text, with Member of... made title text.

Demo and Q/A

Hovering over the icons in the person overview should show Member of [team].

lint
= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/templates/person-portlet-contact-details.pt

-- 
https://code.launchpad.net/~jcsackett/launchpad/member-icons-title/+merge/32269
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/member-icons-title into lp:launchpad/devel.

=== modified file 'lib/lp/registry/templates/person-portlet-contact-details.pt'
--- lib/lp/registry/templates/person-portlet-contact-details.pt	2010-08-03 20:58:54 +0000
+++ lib/lp/registry/templates/person-portlet-contact-details.pt	2010-08-10 21:54:50 +0000
@@ -83,6 +83,7 @@
       <a tal:repeat="team context/@@+restricted-membership/teams_with_icons"
          tal:attributes="href team/fmt:url"
         ><img tal:attributes="src team/icon/getURL;
+                              title string:Icon of ${team/name}
                               title string:Icon of ${team/name}"
       /></a>
     </div>