launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #00606
Re: [Merge] lp:~jelmer/launchpad/update-bzr-git into lp:launchpad/devel
Review: Approve
As stated on IRC, the test fixes look ok, but I recommend moving the import statements up to the top of the file, and using .getUniqueString() for the message instead of 'dsadsa'.
Good to go, r=mars
Maris
--
https://code.launchpad.net/~jelmer/launchpad/update-bzr-git/+merge/32527
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jelmer/launchpad/update-bzr-git into lp:launchpad/devel.
References