launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/bug-619533-sbuild-package-arch into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #619533 sbuild-package suite and arch_tag arguments around the wrong way
  https://bugs.launchpad.net/bugs/619533


This launchpad-buildd branch swaps sbuild-package's suite and architecturetag arguments, so they're in the order that lp-buildd expects. This fixes amd64 builds (bug #619533).

This has already been tested by lamont on a production builder, and it works fine in the i386-on-i386, amd64-on-amd64 and i386-on-amd64 cases.
-- 
https://code.launchpad.net/~wgrant/launchpad/bug-619533-sbuild-package-arch/+merge/33278
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/bug-619533-sbuild-package-arch into lp:launchpad/devel.

=== modified file 'lib/canonical/buildd/sbuild-package'
--- lib/canonical/buildd/sbuild-package	2010-07-13 09:13:41 +0000
+++ lib/canonical/buildd/sbuild-package	2010-08-21 01:46:55 +0000
@@ -19,8 +19,8 @@
 
 SBUILD=/usr/bin/sbuild
 BUILDID=$1
-SUITE=$2
-ARCHITECTURETAG=$3
+ARCHITECTURETAG=$2
+SUITE=$3
 
 shift 3