launchpad-reviewers team mailing list archive

[Edwin Grubbs <edwin.grubbs@xxxxxxxxxxxxx>]

Edwin Grubbs has proposed merging lp:~edwin-grubbs/launchpad/bug-588252-default-radio-button into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #588252 "Registered upstream project" needs a selected radio button
  https://bugs.launchpad.net/bugs/588252


This branch makes the "Choose another upstream project" the default radio button on the source package +index page, when the source package does not have an upstream link already.

You can see the change on this page:
https://launchpad.dev/ubuntu/warty/+source/foobar
-- 
https://code.launchpad.net/~edwin-grubbs/launchpad/bug-588252-default-radio-button/+merge/33466
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~edwin-grubbs/launchpad/bug-588252-default-radio-button into lp:launchpad/devel.

=== modified file 'lib/lp/registry/browser/sourcepackage.py'
--- lib/lp/registry/browser/sourcepackage.py	2010-08-20 20:31:18 +0000
+++ lib/lp/registry/browser/sourcepackage.py	2010-08-23 22:34:41 +0000
@@ -542,7 +542,7 @@
         self.form_fields = Fields(
             Choice(__name__='upstream',
                    title=_('Registered upstream project'),
-                   default=None,
+                   default=self.other_upstream,
                    vocabulary=upstream_vocabulary,
                    required=True))