launchpad-reviewers team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Brad Crittenden has proposed merging lp:~bac/launchpad/bug-429248 into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #429284 Create Package: JBrickShooter
  https://bugs.launchpad.net/bugs/429284


= Summary =

Text describing the status of a project's download files was confusing.

== Proposed fix ==

Change the text.

== Pre-implementation notes ==

Chat with Curtis.

== Implementation details ==

As above.

== Tests ==

bin/test -vvt xx-product-files.txt

== Demo and Q/A ==

https://launchpad.dev/applets


= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:

I'll fix these.

  lib/lp/registry/templates/product-index.pt
  lib/lp/registry/stories/product/xx-product-files.txt

./lib/lp/registry/stories/product/xx-product-files.txt
       1: narrative uses a moin header.
      20: want exceeds 78 characters.
      36: want exceeds 78 characters.
      45: narrative uses a moin header.
     110: narrative uses a moin header.
     159: narrative uses a moin header.
     380: narrative uses a moin header.
     435: narrative uses a moin header.
     474: narrative uses a moin header.
-- 
https://code.launchpad.net/~bac/launchpad/bug-429248/+merge/33684
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bac/launchpad/bug-429248 into lp:launchpad/devel.

=== modified file 'lib/lp/registry/stories/product/xx-product-files.txt'
--- lib/lp/registry/stories/product/xx-product-files.txt	2010-08-02 18:59:44 +0000
+++ lib/lp/registry/stories/product/xx-product-files.txt	2010-08-25 19:26:01 +0000
@@ -9,7 +9,7 @@
     >>> content = find_tag_by_id(anon_browser.contents, 'downloads')
     >>> print extract_text(content)
     Downloads
-    APTonCD does not have any download files.
+    APTonCD does not have any download files registered with Launchpad.
 
 Any user can see a project with a release without files has no downlaod files.
 
@@ -17,7 +17,7 @@
     >>> content = find_tag_by_id(anon_browser.contents, 'downloads')
     >>> print extract_text(content)
     Downloads
-    Mozilla Thunderbird does not have any download files.
+    Mozilla Thunderbird does not have any download files registered with Launchpad.
 
 Any user can see a projects download files organised by series. For each
 series, the owner sees a heading, summary, table of files, and links to each

=== modified file 'lib/lp/registry/templates/product-index.pt'
--- lib/lp/registry/templates/product-index.pt	2010-08-13 21:30:24 +0000
+++ lib/lp/registry/templates/product-index.pt	2010-08-25 19:26:01 +0000
@@ -258,8 +258,8 @@
             tal:attributes="href link/fmt:url;
                             title link/summary">All downloads</a>
            <tal:no-files condition="not: release">
-             <tal:name replace="context/displayname" /> does not have any
-              download files.
+             <tal:name replace="context/displayname" />
+             does not have any download files registered with Launchpad.
            </tal:no-files>
         </p>
       </div>