launchpad-reviewers team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

Deryck Hodge has proposed merging lp:~deryck/launchpad/good-god-comment-fonts-yall into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #624666 Monospace fonts too large after adding Ubuntu font to font-family declaration
  https://bugs.launchpad.net/bugs/624666


This fixes the font issues with bug comments and merge proposal diffs
currently displayed on edge.  I changed the CSS declaration for these
fonts that were using 116%.  They are now 93%, which is one of the
recommended YUI font numbers in the stylesheet.  This corresponds to
12px and matches, at least from my visual scanning, with the sizes
currently showing on lpnet.
-- 
https://code.launchpad.net/~deryck/launchpad/good-god-comment-fonts-yall/+merge/33822
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/good-god-comment-fonts-yall into lp:launchpad/devel.

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css.in'
--- lib/canonical/launchpad/icing/style-3-0.css.in	2010-08-21 13:28:33 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css.in	2010-08-26 18:59:44 +0000
@@ -185,7 +185,8 @@
     width: 60em;
     }
 pre, code, samp, tt, .console {
-    font-size: 116%;
+    font-family: 'UbuntuBeta Mono', 'Ubuntu Mono', monospace;
+    font-size: 93%;
     margin-bottom: 0.8em;
     }
 pre.wrap {
@@ -1092,7 +1093,7 @@
     margin-top: 1em;
     }
 p.search-results {
-    font-size: 116%;
+    font-size: 93%;
     }
 .top-portlet .summary {
     margin: 0 0 1em 0;
@@ -1748,7 +1749,7 @@
     }
 pre.changelog, table.diff,
 .bug-comment, .bug-activity, .codereviewcomment {
-    font-size: 116%;
+    font-size: 93%;
     font-family: 'UbuntuBeta Mono', 'Ubuntu Mono', monospace;
     }
 .cloud-size-smallest {