launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/lucille-archivepermission into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


This branch adds a test for, and corrects an issue I tripped over and cowboyed on mawson while I was QA'ing my change for initialise-from-parent.py
-- 
https://code.launchpad.net/~stevenk/launchpad/lucille-archivepermission/+merge/33873
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/lucille-archivepermission into lp:launchpad/devel.

=== modified file 'database/schema/security.cfg'
--- database/schema/security.cfg	2010-08-23 22:05:26 +0000
+++ database/schema/security.cfg	2010-08-27 06:57:44 +0000
@@ -770,6 +770,7 @@
 public.archive                                  = SELECT, UPDATE
 public.archivearch                              = SELECT
 public.archiveauthtoken                         = SELECT, UPDATE
+public.archivepermission                        = SELECT, INSERT
 public.archivesubscriber                        = SELECT, UPDATE
 public.binarypackagepublishinghistory           = SELECT
 public.gpgkey                                   = SELECT, INSERT, UPDATE

=== modified file 'lib/lp/soyuz/scripts/tests/test_initialise_distroseries.py'
--- lib/lp/soyuz/scripts/tests/test_initialise_distroseries.py	2010-08-26 08:02:08 +0000
+++ lib/lp/soyuz/scripts/tests/test_initialise_distroseries.py	2010-08-27 06:57:44 +0000
@@ -244,6 +244,13 @@
 
     def test_script(self):
         # Do an end-to-end test using the command-line tool
+        uploader = self.factory.makePerson()
+        test1 = getUtility(IPackagesetSet).new(
+            u'test1', u'test 1 packageset', self.hoary.owner,
+            distroseries=self.hoary)
+        test1.addSources('pmount')
+        getUtility(IArchivePermissionSet).newPackagesetUploader(
+            self.hoary.main_archive, uploader, test1)
         foobuntu = self._create_distroseries(self.hoary)
         self._set_pending_to_failed(self.hoary)
         transaction.commit()