← Back to team overview

launchpad-reviewers team mailing list archive

Re: lp:~michael.nelson/launchpad/distro-series-difference-message into lp:launchpad

 

Review: Approve code
Hi Michael,

Thanks for this addition.

I think this would read better if the actual were on a line by itself.

279	+        self.assertEqual(
280	+            "Difference between distroseries 'Lucid' and 'Derilucid' "
281	+            "for package 'foonew' (1.0/0.9)", ds_diff.title)

Otherwise it looks great.
-- 
https://code.launchpad.net/~michael.nelson/launchpad/distro-series-difference-message/+merge/33929
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~michael.nelson/launchpad/distro-series-difference-message into lp:launchpad.



Follow ups

References