launchpad-reviewers team mailing list archive

[Jelmer Vernooij <jelmer@xxxxxxxxx>]

Jelmer Vernooij has proposed merging lp:~jelmer/launchpad/update-bzr-svn into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers): code
Related bugs:
  #480102 assert len(tview) == tview_len
  https://bugs.launchpad.net/bugs/480102
  #616860 Tried registering path as parent while ...
  https://bugs.launchpad.net/bugs/616860
  #616995 non-ascii characters in tag name cause traceback
  https://bugs.launchpad.net/bugs/616995


Update Launchpad to use the latest version of bzr-svn. This newer version fixes a number of bugs, including three that were reported against Launchpad-code. One of these bugs affects a fair number of imports, the other two only cause a couple of imports to fail.

As I've discussed with Tim on IRC a couple of weeks ago, this also increases the number of revisions that is processed by importers for bzr-svn and bzr-git imports. The memory usage in both has been reduced and there is a fair amount of overhead when starting and finishing an import so there is a clear advantage in processing more revisions at a time.

-- 
https://code.launchpad.net/~jelmer/launchpad/update-bzr-svn/+merge/34041
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jelmer/launchpad/update-bzr-svn into lp:launchpad/devel.

=== modified file 'lib/canonical/config/schema-lazr.conf'
--- lib/canonical/config/schema-lazr.conf	2010-08-26 20:26:32 +0000
+++ lib/canonical/config/schema-lazr.conf	2010-08-30 01:02:43 +0000
@@ -472,10 +472,10 @@
 consecutive_failure_limit: 5
 
 # Import only this many revisions from git at once.
-git_revisions_import_limit: 10000
+git_revisions_import_limit: 30000
 
 # Import only this many revisions from svn (via bzr-svn) at once.
-svn_revisions_import_limit: 1000
+svn_revisions_import_limit: 5000
 
 
 [codeimportdispatcher]

=== modified file 'utilities/sourcedeps.conf'
--- utilities/sourcedeps.conf	2010-08-18 14:14:41 +0000
+++ utilities/sourcedeps.conf	2010-08-30 01:02:43 +0000
@@ -2,7 +2,7 @@
 bzr-git lp:~launchpad-pqm/bzr-git/devel;revno=258
 bzr-hg lp:~launchpad-pqm/bzr-hg/devel;revno=282
 bzr-loom lp:~launchpad-pqm/bzr-loom/trunk;revno=48
-bzr-svn lp:~launchpad-pqm/bzr-svn/devel;revno=2709
+bzr-svn lp:~launchpad-pqm/bzr-svn/devel;revno=2710
 cscvs lp:~launchpad-pqm/launchpad-cscvs/devel;revno=432
 dulwich lp:~launchpad-pqm/dulwich/devel;revno=424
 loggerhead lp:~launchpad-pqm/loggerhead/devel;revno=176