launchpad-reviewers team mailing list archive

[Michael Nelson <michael.nelson@xxxxxxxxxxxxx>]

Michael Nelson has proposed merging lp:~michael.nelson/launchpad/test-fix-db-buildbase into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


Testfix for:

https://lpbuildbot.canonical.com/builders/lucid_db_lp/builds/153/steps/shell_7/logs/summary

tested with:

bin/test -vvm lp.buildmaster.tests.test_manager -m lp.code.model.tests.test_sourcepackagerecipebuild -m lp.soyuz.tests.test_binarypackagebuild

which is not all the failures, but enough to show the identified issue of the buildbase import is fixed.
-- 
https://code.launchpad.net/~michael.nelson/launchpad/test-fix-db-buildbase/+merge/34166
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~michael.nelson/launchpad/test-fix-db-buildbase into lp:launchpad.

=== modified file 'lib/lp/buildmaster/manager.py'
--- lib/lp/buildmaster/manager.py	2010-08-30 15:00:23 +0000
+++ lib/lp/buildmaster/manager.py	2010-08-31 07:02:42 +0000
@@ -33,8 +33,7 @@
 from canonical.config import config
 from canonical.launchpad.webapp import urlappend
 from canonical.librarian.db import write_transaction
-from lp.buildmaster.interfaces.buildbase import (
-    BuildStatus, BUILDD_MANAGER_LOG_NAME)
+from lp.buildmaster.enums import BuildStatus
 from lp.services.twistedsupport.processmonitor import ProcessWithTimeout