launchpad-reviewers team mailing list archive

[Jelmer Vernooij <jelmer@xxxxxxxxx>]

Jelmer Vernooij has proposed merging lp:~jelmer/launchpad/optional-assign-lpconfig into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


This trivial branch makes make only set LPCONFIG to development if it hasn't been set in the environment. 

This should prevent the need to specify LPCONFIG=dogfood to make anywhere we use it on dogfood.
-- 
https://code.launchpad.net/~jelmer/launchpad/optional-assign-lpconfig/+merge/34532
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jelmer/launchpad/optional-assign-lpconfig into lp:launchpad/devel.

=== modified file 'Makefile'
--- Makefile	2010-08-31 21:22:27 +0000
+++ Makefile	2010-09-03 12:39:51 +0000
@@ -14,7 +14,7 @@
 SHHH=utilities/shhh.py
 HERE:=$(shell pwd)
 
-LPCONFIG=development
+LPCONFIG?=development
 
 JSFLAGS=
 ICING=lib/canonical/launchpad/icing