← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~wallyworld/launchpad/project-cloud-title into lp:launchpad/devel

 

Ian Booth has proposed merging lp:~wallyworld/launchpad/project-cloud-title into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #336685 Launchpad Code home page misrepresents project cloud
  https://bugs.launchpad.net/bugs/336685


Trivial change to heading text on lp code home page to indicate that the project tag cloud only contains a selection of active projects (not all of them as implied by the previous heading).

Tests:
   - lp/code/stories/branches/xx-bazaar-home.txt
   (modified existing doc test to check for correct page content)
-- 
https://code.launchpad.net/~wallyworld/launchpad/project-cloud-title/+merge/34655
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/project-cloud-title into lp:launchpad/devel.
=== modified file 'lib/lp/code/stories/branches/xx-bazaar-home.txt'
--- lib/lp/code/stories/branches/xx-bazaar-home.txt	2010-08-27 04:53:51 +0000
+++ lib/lp/code/stories/branches/xx-bazaar-home.txt	2010-09-06 05:56:46 +0000
@@ -30,7 +30,7 @@
 
     >>> preview = find_tag_by_id(browser.contents, 'project-cloud-preview')
     >>> print extract_text(preview)
-    Projects with active branches
+    Selection of projects with active branches
     see all projects…
 
     >>> print preview.fetch('a')[-1]['href']

=== modified file 'lib/lp/code/templates/bazaar-index.pt'
--- lib/lp/code/templates/bazaar-index.pt	2010-07-12 14:48:32 +0000
+++ lib/lp/code/templates/bazaar-index.pt	2010-09-06 05:56:46 +0000
@@ -54,7 +54,7 @@
       </p>
 
       <div id="project-cloud-preview" tal:content="cache:public,6 hours">
-        <h2>Projects with active branches</h2>
+        <h2>Selection of projects with active branches</h2>
         <a tal:repeat="product view/short_product_tag_cloud"
            tal:attributes="href product/url;
                            class product/html_class;


Follow ups