launchpad-reviewers team mailing list archive

[Brian Murray <brian@xxxxxxxxxx>]

Only one additional query, per duplicate subscriber, is ran with this change.  Looking at the bug-portlet-dupe-subscribers-content page w/o the changes 27 queries are issued and with the change 28 queries are issued for a bug with one duplicate subscriber.

No, I did not consider reworking the subscribers portlet.  Primarily, because I happened to learning about page templates and how they work and remembered a bug I'd reported and thought it'd be a quick and easy change.  However, the subscriber name is actually shortened (tal:block replace="subscription/person/fmt:displayname/fmt:shorten/20"), to make it fit in the portlet, so that might not work so well.
-- 
https://code.launchpad.net/~brian-murray/launchpad/display-dupe-in-portlet-dupe-subscribers/+merge/34501
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~brian-murray/launchpad/display-dupe-in-portlet-dupe-subscribers into lp:launchpad/devel.