launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Stuart Bishop has proposed merging lp:~stub/launchpad/trivial into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #627741 oops-prune is aborting with a regex mismatch(?)
  https://bugs.launchpad.net/bugs/627741


oops-prune is currently not working as an assert is being triggered.

The assert seems useless except to warn us that the PostgreSQL regular expression could be more efficient, as it is matching rows that our Python code does not mark up as OOPSes. This is fragile and unnecessary.
-- 
https://code.launchpad.net/~stub/launchpad/trivial/+merge/34948
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stub/launchpad/trivial into lp:launchpad/devel.

=== modified file 'lib/canonical/launchpad/scripts/oops.py'
--- lib/canonical/launchpad/scripts/oops.py	2010-08-20 20:31:18 +0000
+++ lib/canonical/launchpad/scripts/oops.py	2010-09-09 06:08:57 +0000
@@ -68,10 +68,6 @@
                 if match.group('oops') is not None:
                     code_string = match.group('oopscode')
                     referenced_codes.add(code_string.upper())
-                    found = True
-            assert found, \
-                'PostgreSQL regexp matched content that Python regexp ' \
-                'did not (%r)' % (content,)
 
     return referenced_codes