launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

Robert Collins has proposed merging lp:~lifeless/launchpad/librarian into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #86185 Librarian should log OOPS reports
  https://bugs.launchpad.net/bugs/86185


Avoid unnecessary work FTW.

I'll also propose for a CP after we see how much it helps edge.
-- 
https://code.launchpad.net/~lifeless/launchpad/librarian/+merge/35053
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~lifeless/launchpad/librarian into lp:launchpad/devel.

=== modified file 'lib/canonical/launchpad/database/librarian.py'
--- lib/canonical/launchpad/database/librarian.py	2010-09-06 21:02:44 +0000
+++ lib/canonical/launchpad/database/librarian.py	2010-09-10 00:36:14 +0000
@@ -236,7 +236,7 @@
 
     @property
     def deleted(self):
-        return self.content is None
+        return self.contentID is None
 
     def __storm_invalidated__(self):
         """Make sure that the file is closed across transaction boundary."""