launchpad-reviewers team mailing list archive

[LaMont Jones <lamont.jones@xxxxxxxxxx>]

LaMont Jones has proposed merging lp:~lamont/launchpad/bug-634859 into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


Change the UI name of builder.active to reduce confusion about its meaning.
-- 
https://code.launchpad.net/~lamont/launchpad/bug-634859/+merge/35091
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~lamont/launchpad/bug-634859 into lp:launchpad/devel.

=== modified file 'lib/lp/buildmaster/interfaces/builder.py'
--- lib/lp/buildmaster/interfaces/builder.py	2010-08-25 16:25:02 +0000
+++ lib/lp/buildmaster/interfaces/builder.py	2010-09-10 12:26:01 +0000
@@ -147,7 +147,7 @@
                       'buildd-slave, e.g.: foobar-host.ppa'))
 
     active = Bool(
-        title=_('Active'), required=True, default=True,
+        title=_('Publicly Visible'), required=True, default=True,
         description=_('Whether or not to present the builder publicly.'))
 
     slave = Attribute("xmlrpclib.Server instance corresponding to builder.")