launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/launchpad/bug-637868 into lp:launchpad/devel.

Requested reviews:
  Robert Collins (lifeless)
  Launchpad code reviewers (launchpad-reviewers): code
Related bugs:
  #637868 2.6-ism in +templates optimization
  https://bugs.launchpad.net/bugs/637868


= Bug 637868 =

Fixes a python 2.6-ism that was breaking the Translations +templates pages on Hardy systems.

To test:
{{{
./bin/test -vvc lp.translations -t series-templates
}}}

Try this on Hardy, or it'll be too easy!

No lint.


Jeroen
-- 
https://code.launchpad.net/~jtv/launchpad/bug-637868/+merge/35373
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/bug-637868 into lp:launchpad/devel.

=== modified file 'lib/lp/translations/browser/potemplate.py'
--- lib/lp/translations/browser/potemplate.py	2010-09-11 09:37:13 +0000
+++ lib/lp/translations/browser/potemplate.py	2010-09-14 08:32:55 +0000
@@ -968,7 +968,8 @@
             ('actions_column', actions_header),
             ]
         return '\n'.join([
-            self._renderField(*column, tag='th') for column in columns])
+            self._renderField(css, text, tag='th')
+            for (css, text) in columns])
 
     def renderTemplateRow(self, template):
         """Render HTML for an entire template row."""