launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

Robert Collins has proposed merging lp:~lifeless/launchpad/test into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


Add the external fixtures project as a dependency; this is pretty similar to our existing facilities but with a few differences:
 - it delegates completely to the fixture 
 - the fixtures project is aiming to be a common reference point for several projects (I hope to get zope.testing using it for layer management, for instance)
 - if we migrate across to it we can delete more code from LP.
-- 
https://code.launchpad.net/~lifeless/launchpad/test/+merge/35917
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~lifeless/launchpad/test into lp:launchpad/devel.

=== modified file 'lib/lp/testing/__init__.py'
--- lib/lp/testing/__init__.py	2010-09-09 17:02:33 +0000
+++ lib/lp/testing/__init__.py	2010-09-18 08:29:51 +0000
@@ -75,6 +75,7 @@
     format_registry,
     )
 from bzrlib.transport import get_transport
+import fixtures
 import pytz
 from storm.expr import Variable
 from storm.store import Store
@@ -301,7 +302,7 @@
         debug(False)
 
 
-class TestCase(testtools.TestCase):
+class TestCase(testtools.TestCase, fixtures.TestWithFixtures):
     """Provide Launchpad-specific test facilities."""
 
     def becomeDbUser(self, dbuser):

=== modified file 'setup.py'
--- setup.py	2010-09-07 18:15:01 +0000
+++ setup.py	2010-09-18 08:29:51 +0000
@@ -31,6 +31,7 @@
         'cssutils',
         # Required for pydkim
         'dnspython',
+        'fixtures',
         'FeedParser',
         'feedvalidator',
         'funkload',

=== modified file 'versions.cfg'
--- versions.cfg	2010-09-14 15:04:06 +0000
+++ versions.cfg	2010-09-18 08:29:51 +0000
@@ -19,6 +19,7 @@
 epydoc = 3.0.1
 FeedParser = 4.1
 feedvalidator = 0.0.0DEV-r1049
+fixtures = 0.3
 functest = 0.8.7
 funkload = 1.10.0
 grokcore.component = 1.6