launchpad-reviewers team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Brad Crittenden has proposed merging lp:~bac/launchpad/bug-637102 into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #637102 rocketfuel-setup uses aptitude.  Will break in Maverick.
  https://bugs.launchpad.net/bugs/637102


In Ubuntu 10.10, aptitude is not installed by default.  We could either add it to lp-dev-dependencies or just use apt-get.  I chose the latter.
-- 
https://code.launchpad.net/~bac/launchpad/bug-637102/+merge/36028
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bac/launchpad/bug-637102 into lp:launchpad/devel.

=== modified file 'utilities/rocketfuel-setup'
--- utilities/rocketfuel-setup	2010-08-06 17:39:52 +0000
+++ utilities/rocketfuel-setup	2010-09-20 15:22:43 +0000
@@ -217,7 +217,7 @@
   dpkg -s $pkg | grep -q "^Status: install ok installed"
   if [ $? -ne 0 ]; then
     echo "Installing $pkg package..."
-    sudo aptitude install $pkg
+    sudo apt-get install $pkg
     if [ $? -ne 0 ]; then
       echo "Unable to install $pkg."
       exit 1
@@ -225,7 +225,7 @@
   fi
   }
 
-sudo aptitude update
+sudo apt-get update
 REQUIRED_PACKAGES="launchpad-developer-dependencies apache2 apache2-mpm-worker"
 for pkg in $REQUIRED_PACKAGES; do
   do_install;