← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~michael.nelson/launchpad/644328-blacklist-ui into lp:launchpad

 

I radio button the suggestion since it provides context. If I blacklist all version, I can still see an option to black list one version (and know I have made a mistake). This assumes there are three buttons and each fires an ajax event on change.

I think we have a "Undo" problem in Lp. It needs a standard presentation, an icon and rules about where is goes (like "or  _Cancel_") so that users know what to expect. As Henning remarked in the other review, the text of the action will vary in size and that could make the list of several open rows hard to scan.

-- 
https://code.launchpad.net/~michael.nelson/launchpad/644328-blacklist-ui/+merge/36442
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~michael.nelson/launchpad/644328-blacklist-ui into lp:launchpad.



References