launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Stuart Bishop has proposed merging lp:~stub/launchpad/trivial into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #627741 oops-prune is aborting with a regex mismatch(?)
  https://bugs.launchpad.net/bugs/627741


Make the garbage thread check more robost to stop occasional spurious errors. 

ERROR: lp.codehosting.puller.tests.test_worker.TestWorkerProgressReporting.test_network (subunit.RemotedTestCase)
----------------------------------------------------------------------
_StringException: Text attachment: garbage
------------
[<Thread(Thread-18, started daemon 46983109310224)>]


If tests still fail with this altered check, its not spurious since if they spawned threads that hang around more than 10 seconds they are going to hang around indefinitely and are a leak.
-- 
https://code.launchpad.net/~stub/launchpad/trivial/+merge/36951
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stub/launchpad/trivial into lp:launchpad/devel.