launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Curtis Hovey has proposed merging lp:~sinzui/launchpad/no-schoolbell into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


This is my branch to remove the remaining schoolbell code.

    lp:~sinzui/launchpad/no-schoolbell
    Diff size:
    Launchpad bug:
          https://bugs.launchpad.net/bugs/492070
    Test command: None
    Pre-implementation: no one
    Target release: 10.10


Remove the remaining schoolbell code
------------------------------------

Schoolbell was disabled in before launchpad 1.0 because the calendar was
not a
compelling feature. We maintain code for the obsolete feature years
later. We
can remove it.

These were removed earlier this year.
    ./lib/schoolbell
    ./lib/canonical/launchpad/components/cal.py
    ./doc/calendars.txt

All that remains is
    POTemplateFacets.calendar()


Rules
-----

    * Delete the unused link


QA
--

None.


Lint
----

Linting changed files:
  lib/lp/translations/browser/potemplate.py
-- 
https://code.launchpad.net/~sinzui/launchpad/no-schoolbell/+merge/37097
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~sinzui/launchpad/no-schoolbell into lp:launchpad/devel.

=== modified file 'lib/lp/translations/browser/potemplate.py'
--- lib/lp/translations/browser/potemplate.py	2010-09-25 14:29:32 +0000
+++ lib/lp/translations/browser/potemplate.py	2010-09-30 03:35:56 +0000
@@ -173,11 +173,6 @@
         specifications_link.target = self.target
         return specifications_link
 
-    def calendar(self):
-        calendar_link = self.target_facets.calendar()
-        calendar_link.target = self.target
-        return calendar_link
-
     def branches(self):
         branches_link = self.target_facets.branches()
         if not self._is_product_series: