launchpad-reviewers team mailing list archive

["j.c.sackett" <jonathan.sackett@xxxxxxxxxxxxx>]

The proposal to merge lp:~jcsackett/launchpad/kill-uses-launchpad-for-650648 into lp:launchpad/devel has been updated.

Description changed to:

Summary
=======

Removes the "Uses Launchpad for" section on product and distribution, which is superseded by the involvement menu.

Proposed Fix
============

Remove the section in the templates that displays the "Uses Launchpad for" as well as the UsesLaunchpadMixin used by the Views to determine what to display.

Pre-Implementation Talk
=======================

Spoke with Curtis.

Implementation details
======================

Largely as in proposed.

Removing the code/template section required updating the tests; in some cases rather than showing the positive condition "Translations is enabled," the only path that conformed to the story structure was instead to show the negative "Translations isn't in the disabled list." In other cases it seemed to make more sense to just remove the section of the test checking what usage showed, since it had more to do with manipulating controls. Comments on the stories are invited--I'm not certain it was the best approach.

Tests
=====

Demo and Q/A
============

The "Uses Launchpad for: " section on product/distros should be gone on all pages.

Lint
====

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/browser/distribution.py
  lib/lp/registry/browser/product.py
  lib/lp/registry/stories/distribution/xx-distribution-launchpad-usage.txt
  lib/lp/registry/stories/product/xx-product-launchpad-usage.txt
  lib/lp/registry/templates/distribution-details.pt
  lib/lp/registry/templates/product-index.pt
  lib/lp/translations/stories/project/xx-project-translations.txt
  lib/lp/translations/stories/translationgroups/10-distro-translation-group.txt
  lib/lp/translations/stories/translationgroups/15-product-translation-group.txt


-- 
https://code.launchpad.net/~jcsackett/launchpad/kill-uses-launchpad-for-650648/+merge/37252
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/kill-uses-launchpad-for-650648 into lp:launchpad/devel.