← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~gary/launchpad/bug650343 into lp:launchpad/devel

 

The proposal to merge lp:~gary/launchpad/bug650343 into lp:launchpad/devel has been updated.

Description changed to:

See bug 650343 for the motivation.  This is primarily just reverting the change done described in that bug, because the constraint/problem in the data center email configuration has been resolved.

I kept a spelling correction from the change.  I also changed things per what lint described (e.g., converted to ReST), except for the singleton tuple complaints (e.g., in "log.warning('DKIM error: %r' % (e,))" the linter wants to see "(e, )").

./lib/canonical/launchpad/mail/incoming.py
     126: E231 missing whitespace after ','
     130: E231 missing whitespace after ','
     133: E231 missing whitespace after ','
     134: E231 missing whitespace after ','
     142: E231 missing whitespace after ','
     153: E231 missing whitespace after ','


-- 
https://code.launchpad.net/~gary/launchpad/bug650343/+merge/37633
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~gary/launchpad/bug650343 into lp:launchpad/devel.



References