← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~brian-murray/launchpad/person-subscription-story into lp:launchpad/devel

 

Its good that you've done that but, the '16' and '17' literals are
still dependent on sample data.

If you make this into a pyunit test rather than a doctest, it will
actually be free of sample data dependencies.
(or use ..., but thats potentially risky).

-Rob
-- 
https://code.launchpad.net/~brian-murray/launchpad/person-subscription-story/+merge/37920
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~brian-murray/launchpad/person-subscription-story into lp:launchpad/devel.



References