launchpad-reviewers team mailing list archive

[Julian Edwards <julian.edwards@xxxxxxxxxxxxx>]

Julian Edwards has proposed merging lp:~julian-edwards/launchpad/cp-slow-deathrow into lp:~launchpad-pqm/launchpad/production-devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #656803 Process-death-row taking a Very Long Time with PG8.4
  https://bugs.launchpad.net/bugs/656803


After PG8.4 was put in production the process-death-row script starting
failing. It turns out to be a bad query that 8.3 let us get away with - this
branch fixes the query to remove an unncessary table join.
-- 
https://code.launchpad.net/~julian-edwards/launchpad/cp-slow-deathrow/+merge/37945
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~julian-edwards/launchpad/cp-slow-deathrow into lp:~launchpad-pqm/launchpad/production-devel.

=== modified file 'lib/lp/archivepublisher/deathrow.py'
--- lib/lp/archivepublisher/deathrow.py	2010-08-23 16:51:11 +0000
+++ lib/lp/archivepublisher/deathrow.py	2010-10-08 10:39:44 +0000
@@ -120,8 +120,7 @@
             SourcePackagePublishingHistory.scheduleddeletiondate < %s AND
             SourcePackagePublishingHistory.dateremoved IS NULL AND
             NOT EXISTS (
-              SELECT 1 FROM sourcepackagepublishinghistory as spph,
-                  sourcepackagerelease as spr
+              SELECT 1 FROM sourcepackagepublishinghistory as spph
               WHERE
                   SourcePackagePublishingHistory.sourcepackagerelease =
                       spph.sourcepackagerelease AND
@@ -136,8 +135,7 @@
             BinaryPackagePublishingHistory.scheduleddeletiondate < %s AND
             BinaryPackagePublishingHistory.dateremoved IS NULL AND
             NOT EXISTS (
-              SELECT 1 FROM binarypackagepublishinghistory as bpph,
-                  binarypackagerelease as bpr
+              SELECT 1 FROM binarypackagepublishinghistory as bpph
               WHERE
                   BinaryPackagePublishingHistory.binarypackagerelease =
                       bpph.binarypackagerelease AND