launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

Note that the changes to ignore should_launch are because some services deliberately ignore it - they don't run by default but when explicitly chosen they need to run; their 'should_launch' is defined as 'return False' : we already filter so that only wanted services are attempted, so checking for should_launch on setUp is a harmful (breaks consistency, causes more code) belts-and-braces.
-- 
https://code.launchpad.net/~lifeless/launchpad/run/+merge/38091
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~lifeless/launchpad/run into lp:launchpad/devel.