← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~thumper/launchpad/better-errors-for-translate-path into lp:launchpad/devel

 

Review: Approve
"returns XXX" - that will confuse folk ;)

I sometimes find creating a constant tuple for exceptions useful. You might find it nice here.

caught_errors = (...)
except caught_errors:
  ...


mainly useful when you want the same set in multiple places.
-- 
https://code.launchpad.net/~thumper/launchpad/better-errors-for-translate-path/+merge/38178
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~thumper/launchpad/better-errors-for-translate-path into lp:launchpad/devel.



References