launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

The proposal to merge lp:~allenap/launchpad/ditch-get-bug-notifications-recipients-bug-659085 into lp:launchpad has been updated.

Description changed to:

This is a big branch, but fear not, most of it is moving code and
deletions. I shall guide you though the dark forest...

- tests/test_bugtask_0.py, tests/test_bugtask_1.py and
  tests/test_bugtask_status.py have been folded into
  tests/test_bugtask.py. The first two were left over from the
  automated tree migration.

- test_bugtask_0.py contained one doctest-in-a-doctring which was
  rewritten as a unittest (it's *very* short). It's still called
  test_open_and_resolved_statuses.

- tests/test_bugtask.py and tests/test_bugtask_status.txt have moved
  into model/tests.

- Bug.getStructuralSubscribers() has moved to BugTaskSet. It now
  accepts a list of bugtasks instead of getting them from
  self.bugtasks, and gets the store to use with IStore(Person) rather
  than Store.of(self).

- TestBugStructuralSubscribers has moved from model/tests/test_bug.py
  to model/tests/test_bugtask.py, and is now called.
  TestGetStructuralSubscribers.

- A couple of functions have been changed to use
  BugTaskSet.getStructuralSubscribers() via the utility.

- getBugNotificationRecipients() has been removed, along with its
  associated tests.

I'm sorry it got a bit long. The dependencies of each change cascaded
somewhat.


-- 
https://code.launchpad.net/~allenap/launchpad/ditch-get-bug-notifications-recipients-bug-659085/+merge/38325
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/launchpad/ditch-get-bug-notifications-recipients-bug-659085 into lp:launchpad.