launchpad-reviewers team mailing list archive

[Tim Penhey <tim.penhey@xxxxxxxxxxxxx>]

Tim Penhey has proposed merging lp:~thumper/launchpad/move-garbo-to-lp into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #240067 Launchpad projects need wikis
  https://bugs.launchpad.net/bugs/240067


As pre-garbo work I'm moving the Garbo scripts into lp.scripts and updating imports.
-- 
https://code.launchpad.net/~thumper/launchpad/move-garbo-to-lp/+merge/38473
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~thumper/launchpad/move-garbo-to-lp into lp:launchpad/devel.

=== modified file 'cronscripts/garbo-daily.py'
--- cronscripts/garbo-daily.py	2010-04-27 19:48:39 +0000
+++ cronscripts/garbo-daily.py	2010-10-14 22:38:44 +0000
@@ -13,7 +13,7 @@
 __all__ = []
 
 import _pythonpath
-from canonical.launchpad.scripts.garbo import DailyDatabaseGarbageCollector
+from lp.scripts.garbo import DailyDatabaseGarbageCollector
 
 if __name__ == '__main__':
     script = DailyDatabaseGarbageCollector()

=== modified file 'cronscripts/garbo-hourly.py'
--- cronscripts/garbo-hourly.py	2010-04-27 19:48:39 +0000
+++ cronscripts/garbo-hourly.py	2010-10-14 22:38:44 +0000
@@ -13,7 +13,7 @@
 __all__ = []
 
 import _pythonpath
-from canonical.launchpad.scripts.garbo import HourlyDatabaseGarbageCollector
+from lp.scripts.garbo import HourlyDatabaseGarbageCollector
 
 if __name__ == '__main__':
     script = HourlyDatabaseGarbageCollector()

=== modified file 'lib/lp/bugs/doc/bug-heat.txt'
--- lib/lp/bugs/doc/bug-heat.txt	2010-08-23 22:05:26 +0000
+++ lib/lp/bugs/doc/bug-heat.txt	2010-10-14 22:38:44 +0000
@@ -250,7 +250,7 @@
 The BugHeatUpdater class is used to create bug heat calculation jobs for
 bugs with out-of-date heat.
 
-    >>> from canonical.launchpad.scripts.garbo import BugHeatUpdater
+    >>> from lp.scripts.garbo import BugHeatUpdater
     >>> from canonical.launchpad.scripts import FakeLogger
 
 We'll commit the transaction so that the BugHeatUpdater updates the

=== modified file 'lib/lp/bugs/tests/test_bugwatch.py'
--- lib/lp/bugs/tests/test_bugwatch.py	2010-10-04 19:50:45 +0000
+++ lib/lp/bugs/tests/test_bugwatch.py	2010-10-14 22:38:44 +0000
@@ -26,7 +26,7 @@
     login,
     )
 from canonical.launchpad.interfaces.launchpad import ILaunchpadCelebrities
-from canonical.launchpad.scripts.garbo import BugWatchActivityPruner
+from lp.scripts.garbo import BugWatchActivityPruner
 from canonical.launchpad.scripts.logger import QuietFakeLogger
 from canonical.launchpad.webapp import urlsplit
 from canonical.testing.layers import (

=== modified file 'lib/lp/code/model/tests/test_revision.py'
--- lib/lp/code/model/tests/test_revision.py	2010-10-04 19:50:45 +0000
+++ lib/lp/code/model/tests/test_revision.py	2010-10-14 22:38:44 +0000
@@ -28,7 +28,7 @@
     )
 from canonical.launchpad.interfaces.account import AccountStatus
 from canonical.launchpad.interfaces.lpstorm import IMasterObject
-from canonical.launchpad.scripts.garbo import RevisionAuthorEmailLinker
+from lp.scripts.garbo import RevisionAuthorEmailLinker
 from canonical.launchpad.webapp.interfaces import (
     DEFAULT_FLAVOR,
     IStoreSelector,

=== modified file 'lib/lp/code/model/tests/test_revisionauthor.py'
--- lib/lp/code/model/tests/test_revisionauthor.py	2010-10-04 19:50:45 +0000
+++ lib/lp/code/model/tests/test_revisionauthor.py	2010-10-14 22:38:44 +0000
@@ -12,7 +12,7 @@
 
 from canonical.config import config
 from canonical.launchpad.interfaces.emailaddress import EmailAddressStatus
-from canonical.launchpad.scripts.garbo import RevisionAuthorEmailLinker
+from lp.scripts.garbo import RevisionAuthorEmailLinker
 from canonical.testing.layers import LaunchpadZopelessLayer
 from lp.code.model.revision import (
     RevisionAuthor,

=== modified file 'lib/lp/code/scripts/tests/test_revisionkarma.py'
--- lib/lp/code/scripts/tests/test_revisionkarma.py	2010-10-04 19:50:45 +0000
+++ lib/lp/code/scripts/tests/test_revisionkarma.py	2010-10-14 22:38:44 +0000
@@ -12,7 +12,7 @@
 
 from canonical.config import config
 from canonical.launchpad.database.emailaddress import EmailAddressSet
-from canonical.launchpad.scripts.garbo import RevisionAuthorEmailLinker
+from lp.scripts.garbo import RevisionAuthorEmailLinker
 from canonical.testing.layers import LaunchpadZopelessLayer
 from lp.code.model.revision import RevisionSet
 from lp.code.scripts.revisionkarma import RevisionKarmaAllocator

=== modified file 'lib/lp/hardwaredb/doc/hwdb.txt'
--- lib/lp/hardwaredb/doc/hwdb.txt	2010-10-03 15:30:06 +0000
+++ lib/lp/hardwaredb/doc/hwdb.txt	2010-10-14 22:38:44 +0000
@@ -375,7 +375,7 @@
     ...     u'beeblebrox@xxxxxxxxxxx')
     >>> user.validateAndEnsurePreferredEmail(email)
     >>> transaction.commit()
-    >>> from canonical.launchpad.scripts.garbo import HWSubmissionEmailLinker
+    >>> from lp.scripts.garbo import HWSubmissionEmailLinker
     >>> from lp.testing.logger import MockLogger
     >>> HWSubmissionEmailLinker(log=MockLogger()).run()
     >>> submission = hw_submission_set.getBySubmissionKey(u'unique-id-2')

=== renamed file 'lib/canonical/launchpad/scripts/garbo.py' => 'lib/lp/scripts/garbo.py'
=== added directory 'lib/lp/scripts/tests'
=== added file 'lib/lp/scripts/tests/__init__.py'
=== renamed file 'lib/canonical/launchpad/scripts/tests/test_garbo.py' => 'lib/lp/scripts/tests/test_garbo.py'
--- lib/canonical/launchpad/scripts/tests/test_garbo.py	2010-10-03 15:30:06 +0000
+++ lib/lp/scripts/tests/test_garbo.py	2010-10-14 22:38:44 +0000
@@ -34,7 +34,7 @@
 from canonical.launchpad.database.openidconsumer import OpenIDConsumerNonce
 from canonical.launchpad.interfaces import IMasterStore
 from canonical.launchpad.interfaces.emailaddress import EmailAddressStatus
-from canonical.launchpad.scripts.garbo import (
+from lp.scripts.garbo import (
     DailyDatabaseGarbageCollector,
     HourlyDatabaseGarbageCollector,
     OpenIDConsumerAssociationPruner,

=== modified file 'lib/lp/scripts/utilities/importfascist.py'
--- lib/lp/scripts/utilities/importfascist.py	2010-09-03 04:14:41 +0000
+++ lib/lp/scripts/utilities/importfascist.py	2010-10-14 22:38:44 +0000
@@ -35,7 +35,7 @@
     canonical.launchpad.feed.branch
     lp.code.feed.branch
     canonical.launchpad.interfaces.person
-    canonical.launchpad.scripts.garbo
+    lp.scripts.garbo
     canonical.launchpad.vocabularies.dbobjects
     lp.registry.vocabularies
     canonical.librarian.client