← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~mvo/launchpad/support-timeframe-fix-660433 into lp:launchpad

 

On Fri, Oct 15, 2010 at 8:57 PM, Michael Vogt <michael.vogt@xxxxxxxxxx> wrote:
> Hey Robert, thanks for your review. I'm happy to remove the data. Please note that its empty gz files currently, so the data added to bzr should be small. But I'm fine with removing it as its currently not required (something small binray (one or two stanzas will be required when we test the germinate output though, so advise is welcome how to handle this).

We already have such data elsewhere in the tree, or we can generate it
on demand.

We're currently working on parallel testing too, which means that
tests *cannot* depend on mutating data in the tree.

(and yes, you'll need to have it be a python unittest).

-Rob
-- 
https://code.launchpad.net/~mvo/launchpad/support-timeframe-fix-660433/+merge/38503
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mvo/launchpad/support-timeframe-fix-660433 into lp:launchpad.



References