launchpad-reviewers team mailing list archive

[Abel Deuring <abel.deuring@xxxxxxxxxxxxx>]

(17:52:07) adeuring: deryck: I think it might make sense to change the test setup so that the product owner is not a member of the bug supervisor team; right now, the term "or user.inTeam(pillar.owner)" in canTransitionToStatus() is not executed 
(17:52:53) deryck: adeuring, ok, that's a good idea.  I can do that.
(17:53:07) adeuring: deryck: thanks! another suggestion, before you start ;)
(17:53:16) deryck: sure
(17:55:28) salgado heißt jetzt salgado-lunch
(17:55:30) adeuring: deryck: you don't test at all for celebrities.bug_watch_updater, celebrities.bug_importer, celebrities.janitor. You could add these tests quickly by definig a base class for tests of "extended permissions", where you do not define the user who is tested, then derive the "real" test classes for supervisor, owner and the celebrities.
(17:55:45) adeuring: That should make the tests a bit shorter and more comprehensive
(17:57:44) deryck: sure, I like that idea.  I can do that, too.
(17:57:59) adeuring: deryck: cool, thanks!

-- 
https://code.launchpad.net/~deryck/launchpad/better-testing-for-status-changes/+merge/38552
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/better-testing-for-status-changes into lp:launchpad/devel.