launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #01571
Re: lp:~edwin-grubbs/launchpad/bug-652232-person-code-action-links into lp:launchpad/devel
Review: Approve ui*
Hi Edwin,
This looks good, but although the sidebar is consistent with other pages, the links themselves are not. For instance, the links on bugs.lp.dev/~mark start with a verb to denote the action, as the sidebar used to hold all our action links. My impression is that we're not going to use them for actions anymore, but then I think we should change the link text on the other pages to be consistent with what we have here.
Is there a wiki page or mailing list thread where this standardization has been discussed. That'd help in making sure everybody is on the same page for future work on this front.
--
https://code.launchpad.net/~edwin-grubbs/launchpad/bug-652232-person-code-action-links/+merge/38574
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~edwin-grubbs/launchpad/bug-652232-person-code-action-links into lp:launchpad/devel.
References