launchpad-reviewers team mailing list archive

[Jonathan Lange <jml@xxxxxxxxx>]

Jonathan Lange has proposed merging lp:~jml/launchpad/codebrowse-port-config into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


We now need to deploy codebrowse to machines that already have another codebrowse deployed.  That means we need to use a different port, and to use a different port, we need to be able to configure the port.

This branch moves away from hard-coded literals in the start-loggerhead.py script to actual config variables.  I've made the default in the schema match what the literals were before, so none of the current config files need to be changed.

-- 
https://code.launchpad.net/~jml/launchpad/codebrowse-port-config/+merge/38812
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jml/launchpad/codebrowse-port-config into lp:launchpad/devel.

=== modified file 'lib/canonical/config/schema-lazr.conf'
--- lib/canonical/config/schema-lazr.conf	2010-10-15 17:04:51 +0000
+++ lib/canonical/config/schema-lazr.conf	2010-10-19 08:56:16 +0000
@@ -278,6 +278,16 @@
 # datatype: string
 launchpad_root:
 
+# The IP address to listen on.
+#
+# datatype: string
+listen_host: 0.0.0.0
+
+# The port to listen on.
+#
+# datatype: int
+port: 8080
+
 # A file path that contains a secret used for verifying cookies sent
 # to codebrowse.  This file should ideally contain 64 bytes of random
 # data, and should be considered private -- if it is disclosed, we

=== modified file 'scripts/start-loggerhead.py'
--- scripts/start-loggerhead.py	2010-10-07 06:58:47 +0000
+++ scripts/start-loggerhead.py	2010-10-19 08:56:16 +0000
@@ -21,8 +21,9 @@
 from canonical.config import config
 import lp.codehosting
 
-LISTEN_HOST = '0.0.0.0'
-LISTEN_PORT = 8080
+
+LISTEN_HOST = config.codebrowse.listen_host
+LISTEN_PORT = config.codebrowse.port
 THREADPOOL_WORKERS = 10