launchpad-reviewers team mailing list archive

[Jonathan Lange <jml@xxxxxxxxx>]

Jonathan Lange has proposed merging lp:~jml/launchpad/codebrowse-config-cp into lp:~launchpad-pqm/launchpad/production-devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


This branch cherry picks in a recent change that allows codebrowse's port and IP to be configured, rather than using literals.

The risk is low, since it's a small non-behavioural change.  The reason we're CPing is because Tom has already updated the production config scripts, so if we don't have these new settings in the schema, the next rollout will break.

 <mthaddon> jml: hmm, I landed the change to lp-production-configs 
    but now qastaging auto-update is broken until your branch lands, 
    which means, I think, that we need to also land it on production-devel 
    otherwise the next deployment to production-stable will complain as well

-- 
https://code.launchpad.net/~jml/launchpad/codebrowse-config-cp/+merge/38858
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jml/launchpad/codebrowse-config-cp into lp:~launchpad-pqm/launchpad/production-devel.

=== modified file 'lib/canonical/config/schema-lazr.conf'
--- lib/canonical/config/schema-lazr.conf	2010-10-01 21:10:55 +0000
+++ lib/canonical/config/schema-lazr.conf	2010-10-19 16:24:51 +0000
@@ -278,6 +278,16 @@
 # datatype: string
 launchpad_root:
 
+# The IP address to listen on.
+#
+# datatype: string
+listen_host: 0.0.0.0
+
+# The port to listen on.
+#
+# datatype: int
+port: 8080
+
 # A file path that contains a secret used for verifying cookies sent
 # to codebrowse.  This file should ideally contain 64 bytes of random
 # data, and should be considered private -- if it is disclosed, we

=== modified file 'scripts/start-loggerhead.py'
--- scripts/start-loggerhead.py	2010-08-25 23:40:32 +0000
+++ scripts/start-loggerhead.py	2010-10-19 16:24:51 +0000
@@ -18,8 +18,9 @@
 from canonical.config import config
 import lp.codehosting
 
-LISTEN_HOST = '0.0.0.0'
-LISTEN_PORT = 8080
+
+LISTEN_HOST = config.codebrowse.listen_host
+LISTEN_PORT = config.codebrowse.port
 THREADPOOL_WORKERS = 10