launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

Robert Collins has proposed merging lp:~lifeless/launchpad/threads into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #663644 thread-leak checking logic disable flag not working
  https://bugs.launchpad.net/bugs/663644


Fix our test suite headaches with windmill
-- 
https://code.launchpad.net/~lifeless/launchpad/threads/+merge/38908
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~lifeless/launchpad/threads into lp:launchpad/devel.

=== modified file 'lib/canonical/testing/layers.py'
--- lib/canonical/testing/layers.py	2010-10-17 05:02:20 +0000
+++ lib/canonical/testing/layers.py	2010-10-20 04:06:09 +0000
@@ -331,7 +331,7 @@
                     if thread not in BaseLayer._threads and thread.isAlive()]
 
         if BaseLayer.disable_thread_check:
-            new_threads = new_live_threads()
+            new_threads = None
         else:
             for loop in range(0,100):
                 # Check for tests that leave live threads around early.