launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

Hi, we still need a config setting to control profiling because we do
not ever want it on in prod.

Here's what I think we need, for clarity:
C - config
F - flags
 - on prod
   C - allow_profiling False: no profiling, no how, no way
 - no devel
   C - allow_profiling true: profiling anytime
 - on staging
   C - allow_profiling True:
   F - profiling on request by developers [use a team scope to id the developer]
   F - profiling of all requests [use the default scope to turn it on
for all requests]

That is, the check for 'should we profile' is:
config.allow_profiling and getFeatureFlag('profile') == 'on'

-Rob
-- 
https://code.launchpad.net/~mars/launchpad/add-profiling-feature-flag/+merge/39179
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mars/launchpad/add-profiling-feature-flag into lp:launchpad/devel.