launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/zope-pagetemplate-fix into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


This change is just to include a patched version of zope.pagetemplate 3.5.0
The patch has been approved by the zope maintainers but is not yet merged into the official release.
The purpose of the patch is to fix an isinstance() check in the traversal code to allow short circuiting to occur when subclasses of dict() are navigated.

Tests

Same tests as used to the menu performance improvements branch
eg bin/test -vvt menus.txt


-- 
https://code.launchpad.net/~wallyworld/launchpad/zope-pagetemplate-fix/+merge/39828
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/zope-pagetemplate-fix into lp:launchpad/devel.

=== modified file 'versions.cfg'
--- versions.cfg	2010-10-27 04:23:52 +0000
+++ versions.cfg	2010-11-02 08:59:47 +0000
@@ -207,7 +207,12 @@
 zope.login = 1.0.0
 zope.minmax = 1.1.1
 zope.modulealias = 3.4.0
-zope.pagetemplate = 3.5.0
+# Build of lp:~wallyworld/zope.pagetemplate/fix-isinstance
+# This version adds a small change to the traversal logic so that the
+# optimisation which applies if the object is a dict also works for subclasses
+# of dict. The change has been approved for merge into the official zope code
+# base. This patch is a temporary fix until the next official release.
+zope.pagetemplate = 3.5.0-p1
 zope.password = 3.5.1
 zope.principalannotation = 3.6.0
 zope.principalregistry = 3.7.0